Some improvements #53
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e error handling when extracting
|
Thanks for the PR! |
Comment on lines
+164
to
+165
| parser.add_argument("-s","--sql", dest="sql", action="store", default=None, help="Hostname of SQL server") | ||
| parser.add_argument("-b","--brand", dest="brand", action="store", default=None, help="Brand of the firmware image") |
There was a problem hiding this comment.
We are not using PostgreSQL database to store information about the emulated images.
From README,
Firmware Analysis Toolkit (FAT henceforth) is based on Firmadyne with some changes. Firmadyne uses a PostgreSQL database to store information about the emulated images. However just for the core functionality i.e. emulating firmware, PostgreSQL is not really needed. Hence FAT doesn't use it.
There was a problem hiding this comment.
Yes, FAT does not need it. I guess it won't harm to pass those parameter to firmadyne so user can use FAT even if they need the firmadyne sql feature/need to do some manual task with firmadyne later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove 1000 images limit
fix typo in message
reuse image ID if the same firmware has been extracted before, improve error handling when extracting